This repository has been archived by the owner on Jan 2, 2023. It is now read-only.
Parse link hrefs assuming they are percent encoded #5273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Parse href infindLinks
withQUrl::fromPercentEncoding
QUrl::fromEncoded()
andQUrl::toEncoded()
instead ofQUrl(string)
andQUrl::toString()
Details
This allows for both internal and external links containing percent escaped characters to be parsed correctly. Previously,
http://example.com/foo%26bar
was parsed ashttp://example.com/foo%2526bar
instead ofhttp://example.com/foo%26bar
(http://example.com/foo&bar
). Same issue for other escaped characters.Fixes #4406
Fixes #5257